add BucketOwnerPreferred ownership controls to buckets w/ aws_s3_bucket_acl resources #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As announced by AWS, Amazon S3 is disabling S3 access control lists (ACLs) for all new S3 buckets. As a result, using the
aws_s3_bucket_acl
resource to create an ACL for a bucket -- one which does not already have ownership controls in place -- will fail, unless bucket ownership has already been configured:Per the recommendation in the Terraform AWS Provider, this PR adds an
aws_s3_bucket_ownership_controls
resource (set toBucketOwnerPreferred
) for every bucket in this repo that also has anaws_s3_bucket_acl
resource, and waits until the ownership controls have been set (viadepends_on
) before creating the ACL.