Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made All the pages Responsive with navbar #96

Closed
wants to merge 4 commits into from
Closed

Made All the pages Responsive with navbar #96

wants to merge 4 commits into from

Conversation

ZaidKhan2002
Copy link

@ZaidKhan2002 ZaidKhan2002 commented Dec 25, 2021

Thank you for your contribution to Bloody-Buddy 🤩🤩

GitHub license Open Source Love PRs Welcome

Please mention the following in order to get PR merged 🙌🏻🙌🏻

  1. Kind of change this PR introduce : Made all the pages responsive with navbar
  2. Issue it resolves : Responsive Website #77
  3. GitHub Page Link : https://zaidkhan2002.github.io/Blood-Buddy/

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZaidKhan2002 In every page there's some error or another like some of them I've mentioned here :

  1. Don't change alignments and color :
    image

  2. Tab view, the text is half visible
    Screenshot 2021-12-25 at 17-07-46 BLOOD BUDDY

  3. Distorted Mobile View
    Screenshot 2021-12-25 at 17-07-38 BLOOD BUDDY

@ZaidKhan2002
Copy link
Author

Ohh Actually I have not even changed single file/page regarding this still I'll fix this and commit changes. Actually If there is another PR made committed to main page then there is merge conflict and then we have to pull the changes and write our code again so maybe that time this happen. Anyways I am fixing this right away.

@ZaidKhan2002
Copy link
Author

I have done the changes if anything more is required from my side do let me know @2024-SANDHYA

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on index.html page :

  1. You've paused the video in the background

  2. Removed hover effects from register button

  3. Alignment of register is wrong :
    image

  4. Here, the padding and margin needs to be checked
    image

On donate page:

  1. You made font size way too small, please don't play with this
    image

  2. Nav bar is literally at the top, no padding or margin you've added, please restore it to previous one

image

  1. In the tab view, see the navbar
    image

  2. In mobile view, the whole thing is distorted, see the footer and also where's the main content is going, way too high
    image

  3. Hover effects on this in mobile view are looking bad, restore it to previous one please don't play with this

image

Same you've done with get help page @ZaidKhan2002 No padding or margin and etc..

@ZaidKhan2002
Copy link
Author

@2024-SANDHYA I don't know how these changes are happening like you can check the changes I've made by going to this Here you can see I have not played/changed any one the things mentioned above regarding font size or hover effect or sizing etc etc. And also on my device video is playing perfectly navbar is fully responsive both in mobile and in tablet. Again I'll commit the requested changes by tomorrow and then you can check.

@2024-SANDHYA
Copy link
Owner

No issues @ZaidKhan2002 Take your time. Sometimes margin padding happens by default too.

@ZaidKhan2002
Copy link
Author

@2024-SANDHYA can you check now !!

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts @ZaidKhan2002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive Website
2 participants