-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made All the pages Responsive with navbar #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZaidKhan2002 In every page there's some error or another like some of them I've mentioned here :
Ohh Actually I have not even changed single file/page regarding this still I'll fix this and commit changes. Actually If there is another PR made committed to main page then there is merge conflict and then we have to pull the changes and write our code again so maybe that time this happen. Anyways I am fixing this right away. |
I have done the changes if anything more is required from my side do let me know @2024-SANDHYA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on index.html page :
-
You've paused the video in the background
-
Removed hover effects from register button
On donate page:
-
You made font size way too small, please don't play with this
-
Nav bar is literally at the top, no padding or margin you've added, please restore it to previous one
-
In mobile view, the whole thing is distorted, see the footer and also where's the main content is going, way too high
-
Hover effects on this in mobile view are looking bad, restore it to previous one please don't play with this
Same you've done with get help page @ZaidKhan2002 No padding or margin and etc..
@2024-SANDHYA I don't know how these changes are happening like you can check the changes I've made by going to this Here you can see I have not played/changed any one the things mentioned above regarding font size or hover effect or sizing etc etc. And also on my device video is playing perfectly navbar is fully responsive both in mobile and in tablet. Again I'll commit the requested changes by tomorrow and then you can check. |
No issues @ZaidKhan2002 Take your time. Sometimes margin padding happens by default too. |
@2024-SANDHYA can you check now !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the merge conflicts @ZaidKhan2002
Thank you for your contribution to Bloody-Buddy 🤩🤩
Please mention the following in order to get PR merged 🙌🏻🙌🏻