Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version of configurator #1017

Closed
wants to merge 2 commits into from
Closed

Bump version of configurator #1017

wants to merge 2 commits into from

Conversation

yuvipanda
Copy link
Member

@yuvipanda
Copy link
Member Author

Will need to be decoupled from the hub image soon, so we can iterate on the configurator faster / better.

GeorgianaElena
GeorgianaElena approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@yuvipanda yuvipanda marked this pull request as draft February 22, 2022 15:51
@choldgraf
Copy link
Member

any reason this is still in draft mode? when will it be time to merge this?

@damianavila
Copy link
Contributor

@yuvipanda, do you want to do anything else here before migrating this one off the draft state?

@yuvipanda
Copy link
Member Author

@damianavila i think this won't actually work - right now, configurator ships with built js in the repo (https://github.com/yuvipanda/jupyterhub-configurator/blob/main/jupyterhub_configurator/static/index.js) and I think the last PR didn't actually commit the built JS

@GeorgianaElena GeorgianaElena mentioned this pull request Mar 10, 2022
Merged
@GeorgianaElena
Copy link
Member

@yuvipanda, @damianavila , sorry about missing to add that file to the PR. I opened yuvipanda/jupyterhub-configurator#12 to address this.

@damianavila
Copy link
Contributor

Do we want to also merge yuvipanda/jupyterhub-configurator#11 before updating this one with a new tag?

@consideRatio
Copy link
Contributor

I'll pre-emptively close this as it seems no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

@damianavila damianavila damianavila approved these changes

Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuvipanda @choldgraf @damianavila @GeorgianaElena @consideRatio