Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags.SafeUrl() doesnt encode apostrophe in a Url #3

Closed
kieran23101 opened this issue Sep 7, 2020 · 1 comment
Closed

Tags.SafeUrl() doesnt encode apostrophe in a Url #3

kieran23101 opened this issue Sep 7, 2020 · 1 comment

Comments

@kieran23101
Copy link
Contributor

I have on our website I have had to add a temporary ".Replace("'", "%27")" to fix the issue but im sure there is a much better way to do this.

Is this a bug or is it supposed to do this?

Regards

Kieran Corkin

@iJungleboy
Copy link
Contributor

iJungleboy commented Sep 7, 2020

@kieran23101 not sure about this.

Seems to be a know issue https://stackoverflow.com/questions/561954/asp-net-urlencode-ampersand-for-use-in-query-string - something about backward compatibility.

If you can, please submit a change / pull request. it would be needed here

return Uri.EscapeUriString(url);

iJungleboy added a commit that referenced this issue Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants