Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrtool 1.2.0 fails to parse CIA signatures when built with optimizations #145

Open
leo60228 opened this issue Nov 2, 2023 · 3 comments

Comments

@leo60228
Copy link

leo60228 commented Nov 2, 2023

After updating ctrtool from 0.7 to 1.2.0, I get an [ntd::n3ds::es::SignatureDeserialiser ERROR] Unexpected signature type. error for all CIA files I have, including homebrew like FBI (from https://github.com/Steveice10/FBI/releases/download/2.6.1/FBI.cia) when building with optimizations.

@leo60228 leo60228 changed the title ctrtool 1.2.0 fails to parse CIA signatures, but ctrtool 0.7 succeeds ctrtool 1.2.0 fails to parse CIA signatures when built with optimizations Nov 2, 2023
@jakcron
Copy link
Collaborator

jakcron commented Sep 7, 2024

Sorry for the late comment. There’s some stuff that’s unclear to me.

Are you building CTRTool yourself or is this a build that’s included on the GH release?

What platform/architecture are you running CTRTool under.

And if you are building CTRTool yourself, what optimisations are you including?

@leo60228
Copy link
Author

leo60228 commented Sep 7, 2024

Are you building CTRTool yourself or is this a build that’s included on the GH release?

The former.

What platform/architecture are you running CTRTool under.

Linux, x86_64

And if you are building CTRTool yourself, what optimisations are you including?

-O2. This is enabled by default for all packages built in Nixpkgs to ensure _FORTIFY_SOURCE applies.

@jakcron
Copy link
Collaborator

jakcron commented Sep 7, 2024

Awesome thank you, I'll try to reproduce this and release a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants