Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrtool: 0.7 -> 1.2.0 #264915

Merged
merged 1 commit into from
Jun 11, 2024
Merged

ctrtool: 0.7 -> 1.2.0 #264915

merged 1 commit into from
Jun 11, 2024

Conversation

leo60228
Copy link
Member

@leo60228 leo60228 commented Nov 2, 2023

Description of changes

See changelogs for ctrtool 1.0.0 (a near-complete rewrite), 1.1.0, and 1.2.0. I've also added a passthru.updateScript using gitUpdater.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@leo60228
Copy link
Member Author

leo60228 commented Nov 2, 2023

This possibly shouldn't be merged yet. Most functionality seems fine, but I found 3DSGuy/Project_CTR#145 while testing.

@leo60228
Copy link
Member Author

leo60228 commented Nov 2, 2023

Building with -O0 seems to act as a workaround.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 2, 2023
@pbsbot
Copy link

pbsbot commented Jun 11, 2024

Result of nixpkgs-review pr 264915 run on x86_64-linux 1

1 package built:
  • ctrtool

@pbsds pbsds merged commit 89386a9 into NixOS:master Jun 11, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants