Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vietnamese dict #539

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Vietnamese dict #539

wants to merge 12 commits into from

Conversation

dalmatele
Copy link

No description provided.

@3rdIteration
Copy link
Owner

3rdIteration commented Jan 1, 2025 •
edited
Loading

Thanks for the PR.

A few issues

  • Please remove the changes that remove the tip addresses that put yours in instead...
  • Please rebase with latest code that fixes the dogechain info wallet for the latest types (or just remove these changes, as your implementation doesn't actually fix it)
  • Please add additional argument to toggle between saving an encrypted password and displaying it in the console
  • Please remove all networking code
  • The vietnamese dict tool should probably just go in the folder with the other tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalmatele @3rdIteration