Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggers errors on VS Code json files #81

Closed
segevfiner opened this issue Sep 29, 2020 · 1 comment · Fixed by #87
Closed

Triggers errors on VS Code json files #81

segevfiner opened this issue Sep 29, 2020 · 1 comment · Fixed by #87

Comments

@segevfiner
Copy link

VS Code uses a special dialect of JSON for it's configuration files that supports comments and trailing comma. This extension tries to parse such files triggering JSON parsing errors when they contain such elements. This extension should not generate such errors, maybe even ignoring such files in the first place.

To reproduce:

  1. Open VS Code settings.json, and have a trailing comma in the top level JSON object. This is valid in VS Code, but this extension tries to parse it and raises errors about it.
@segevfiner segevfiner changed the title Extensions triggers errors on VS Code json files Triggers errors on VS Code json files Sep 30, 2020
@ak1394
Copy link
Collaborator

ak1394 commented Oct 5, 2020

Thanks for reporting! Our extension should in fact support JSONC, so this behaviour is likely a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants