Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build 1.13.0 #698

Closed
ArchangeGabriel opened this issue Jan 31, 2019 · 10 comments
Closed

Unable to build 1.13.0 #698

ArchangeGabriel opened this issue Jan 31, 2019 · 10 comments

Comments

@ArchangeGabriel
Copy link

Describe the bug
During build:

go: verifying github.com/labstack/[email protected]+incompatible: checksum mismatch
	downloaded: h1:Y3vG4kINVWNQN8Y6Jdur8uLat7fSLV5n5yLE8n+JbF4=
	go.sum:     h1:9PfxPUmasKzeJor9uQTaXLT6WUG/r+vSTmvXxvv3JO4=

To Reproduce
Get the sources, extract them, run go build -v.

Expected behavior
Building fine.

Environment (please complete the following information):

  • OS: ArchLinux
  • Matterbridge version: 1.13.0
@42wim
Copy link
Owner

42wim commented Jan 31, 2019

Quick search finds: golang/go#29278

Quick fix for you is to do a go build -mod vendor that should build.

I'll look later for a better solution.

@ArchangeGabriel
Copy link
Author

Well a better solution is apparently upgrading the checksum, but this requires everyone to build with go 1.11.4+. Since the issue is known, for now I’ll just sed the corresponding sum locally.

@42wim
Copy link
Owner

42wim commented Jan 31, 2019

labstack/echo#1272 could also be related instead of an issue with go

@ArchangeGabriel
Copy link
Author

It definitively is. They moved the tag, so the checksum does not match. Wether they will move it back or not is currently unsure.

@42wim 42wim closed this as completed in c81c0dd Jan 31, 2019
@alexaandru
Copy link

The tags were just restored, I apologize for the inconvenience. Could you please confirm that you can build ok?

@42wim
Copy link
Owner

42wim commented Jan 31, 2019

@alexaandru race condition here, I've just released a new version using labstack/echo/v4 :-)
Just tested again with v1.13.0 and this release now builds also ok.
Thanks!

@ArchangeGabriel
Copy link
Author

@alexaandru I can also confirm it builded OK here. :)

@42wim That was the better thing to do anyway. ;)

@alexaandru
Copy link

Thank you very much! :) Just please make sure that using V4 won't cause any issues, it is a major release after all. Please make sure you do read the release notes to spare you of any trouble: https://github.com/labstack/echo/releases/tag/v4.0.0 and the README: https://github.com/labstack/echo/tree/v4.0.0#supported-go-versions

Have a great day!

@42wim
Copy link
Owner

42wim commented Jan 31, 2019

@alexaandru thanks, btw regarding to go-versions I can still build matterbridge with go1.9.x because of the fact I'm also still using go mod vendor to have the vendor directory available for older versions (which still works fine with the /v4 change of echo)

@alexaandru
Copy link

Very nice, great then! :)

zeridon pushed a commit to zeridon/matterbridge that referenced this issue Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants