Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add zip_safe option #1

Merged
merged 1 commit into from
Jan 21, 2018
Merged

Conversation

Kristinita
Copy link

1. Summary

I add zip_safe parameter. pyroma requires, that setup.cfg contains it.

2. Steps to reproduce

I clone update/distribute branch of your repository → I run pyroma in repository folder.

3. Behavior before pull request

D:\sampleproject>pyroma .
------------------------------
Checking .
Found sample
------------------------------
You are using Setuptools or Distribute but do not specify if this package is zip_safe or not. You should specify it, as it defaults to True, which you probably do not want.
------------------------------
Final rating: 9/10
Cottage Cheese
------------------------------

4. Behavior after pull request

D:\sampleproject>pyroma .
------------------------------
Checking .
Found pyfancy
------------------------------
Final rating: 10/10
Your cheese is so fresh most people think it's a cream: Mascarpone
------------------------------

5. Testing environment

  • Windows 10 Enterprise LTSB 64-bit EN,
  • Python 3.6.4,
  • pyroma 2.3.

Thanks.

@4383
Copy link
Owner

4383 commented Jan 21, 2018

Hi @Kristinita!

thanks for your fix.

@4383 4383 merged commit c503301 into 4383:update/distribute Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants