fix: Support ? characters in serializer base

Closes #812.

packages/nuqs/src/serializer.test.ts

@@ -188,4 +188,17 @@ describe('serializer', () => {
     const result = serialize({ str: 'foo', int: 1, bool: true })
     expect(result).toBe('?s=foo&i=1&b=true')
   })
+  it('supports ? in the values', () => {
+    const serialize = createSerializer(parsers)
+    const result = serialize({ str: 'foo?bar', int: 1, bool: true })
+    expect(result).toBe('?str=foo?bar&int=1&bool=true')
+  })
+  it('supports & in the base', () => {
+    // Repro for https://github.com/47ng/nuqs/issues/812
+    const serialize = createSerializer(parsers)
+    const result = serialize('https://example.com/path?issue=is?here', {
+      str: 'foo?bar'
+    })
+    expect(result).toBe('https://example.com/path?issue=is?here&str=foo?bar')
+  })
 })

packages/nuqs/src/serializer.ts

@@ -81,8 +81,8 @@ function isBase(base: any): base is Base {
 
 function splitBase(base: Base) {
   if (typeof base === 'string') {
-    const [path = '', search] = base.split('?')
-    return [path, new URLSearchParams(search)] as const
+    const [path = '', ...search] = base.split('?')
+    return [path, new URLSearchParams(search.join('?'))] as const
   } else if (base instanceof URLSearchParams) {
     return ['', new URLSearchParams(base)] as const // Operate on a copy of URLSearchParams, as derived classes may restrict its allowed methods
   } else {