-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subscribeToQueryUpdates
is not reactive when using Next.js v14.0.3
#422
Comments
Yes, I'm afraid that with recent changes in the app router core, I'll have to deprecate this function. If you turn on the |
Road to v2? |
@Talent30 when the But that's probably quite far down the line, I expect the Next.js team wants to get some folks onboard testing shallow routing first. |
It was broken in Next.js 14.0.3 due to shallow updates not calling the patched history methods, and fixed in Next.js 14.0.4. However, since turning on the `windowHistorySupport` flag causes `useSearchParams` to be reactive to shallow URL query changes, there's no longer need for this method. Marking it as deprecated now, and will be dropped along with other deprecations in v2.0.0 once WHS lands in GA. Closes #422.
This is fixed in Next.js 14.0.4, both with or without the I'll still mark the method as deprecated as it's an internal thing that won't make much sense once proper reactivity of |
It was broken in Next.js 14.0.3 due to shallow updates not calling the patched history methods, and fixed in Next.js 14.0.4. However, since turning on the `windowHistorySupport` flag causes `useSearchParams` to be reactive to shallow URL query changes, there's no longer need for this method. Marking it as deprecated now, and will be dropped along with other deprecations in v2.0.0 once WHS lands in GA. Closes #422.
🎉 This issue has been resolved in version 1.13.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 1.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Reproduction
https://codesandbox.io/p/devbox/winter-sound-6y9rv3
Preview Code
Tech Stack
react
18
next
14.0.3
next-usequerystate
1.13.0
basePath
option in your Next.js configwindowHistorySupport
flag in your Next.js configThe text was updated successfully, but these errors were encountered: