generated from chiffre-io/template-library
-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Deprecate subscribeToQueryUpdates
#425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was broken in Next.js 14.0.3 due to shallow updates not calling the patched history methods, and fixed in Next.js 14.0.4. However, since turning on the `windowHistorySupport` flag causes `useSearchParams` to be reactive to shallow URL query changes, there's no longer need for this method. Marking it as deprecated now, and will be dropped along with other deprecations in v2.0.0 once WHS lands in GA. Closes #422.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franky47
changed the title
fix: Deprecate subscribeToQueryUpdates
fix: Deprecate Dec 8, 2023
subscribeToQueryUpdates
🎉 This PR is included in version 1.13.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
franky47
added a commit
that referenced
this pull request
Jan 15, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Jan 17, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Jan 17, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Feb 5, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Feb 5, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Feb 17, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Mar 21, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Mar 26, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Apr 21, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
May 13, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
May 19, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
May 19, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
May 19, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Jun 26, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Jun 26, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Jun 26, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Jul 20, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Jul 25, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Aug 30, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Sep 6, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Sep 24, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Sep 28, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Oct 3, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Oct 9, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Oct 10, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Oct 10, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Oct 11, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Oct 21, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
franky47
added a commit
that referenced
this pull request
Oct 22, 2024
BREAKING CHANGE: the following deprecated APIs have been removed: - `queryTypes` bag of parsers -> use individual `parseAsXYZ` parsers for better tree-shakeability. - `subscribeToQueryUpdates` helper -> since Next.js 14.0.5, `useSearchParams` is reactive to shallow search params updates in the app router. See #425. - Internal types and aliases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was broken in Next.js 14.0.3 due to shallow updates not calling the patched history methods, and fixed in Next.js 14.0.4.
However, since turning on the
windowHistorySupport
flag causesuseSearchParams
to be reactive to shallow URL query changes, there's no longer need for this method.Marking it as deprecated now, and will be dropped along with other deprecations in v2.0.0 once WHS lands in GA.
Closes #422.