Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch debug logging to console.log #398

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Switch debug logging to console.log #398

merged 3 commits into from
Nov 16, 2023

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Nov 16, 2023

  • Change the debugging logging from console.debug to console.log so logging is visible without changing the log level to "verbose"
  • Simplify readme wording in the debug section

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-usequerystate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 7:13am

@franky47
Copy link
Member

To be fair it made sense to use console.debugin early versions of the library when debugging info was always printed out, but we could go with console.log now (and save two bytes along the way).

Would you like to change your PR to do that?

Relevant code is in packages/next-usequerystate/src/debug.ts

@tordans tordans changed the title Readme: Clarify log level for debugging Switch debug logging to console.log Nov 16, 2023
@tordans
Copy link
Contributor Author

tordans commented Nov 16, 2023

@franky47 I updated the PR. I can squash the commits, if you like. But that should also work with the Github Squash-Merge if that is enabled.

Anything else here?

Copy link
Member

@franky47 franky47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll do the squash and merge to use the proper SemRel semantics. Thanks!

@franky47 franky47 enabled auto-merge (squash) November 16, 2023 07:38
@franky47 franky47 disabled auto-merge November 16, 2023 07:40
@franky47 franky47 merged commit 91b64a9 into 47ng:next Nov 16, 2023
1 check passed
Copy link

🎉 This PR is included in version 1.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants