Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Install Next.js versions to both e2e & nuqs #678

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

franky47
Copy link
Member

This solves some incompatibilities when running tests related to the React version embedded by Next and exported by nuqs.

Symptom was that all pages in the pages router crashed on mount.

Supersedes #677, which attempted to use the catalogs feature of pnpm to keep things in sync, but isn't practical to inject custom versions in a CI context.

This solves some incompatibilities when running tests related to the React version
embedded by Next and exported by nuqs.

Symptom was that all pages in the pages router crashed on mount.

Supersedes #677, which attempted to use the catalogs feature of pnpm to keep things in sync,
but isn't practical to inject custom versions in a CI context.
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 7:29pm

@franky47 franky47 enabled auto-merge (squash) October 11, 2024 19:27
@franky47 franky47 merged commit 446e664 into next Oct 11, 2024
20 checks passed
@franky47 franky47 deleted the chore/sync-nuqs-e2e-next-versions branch October 11, 2024 19:29
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant