Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Document testing nuqs based hooks #795

Merged
merged 2 commits into from
Dec 10, 2024
Merged

docs: Document testing nuqs based hooks #795

merged 2 commits into from
Dec 10, 2024

Conversation

sebastianvitterso
Copy link
Contributor

@sebastianvitterso sebastianvitterso commented Dec 7, 2024 •
edited by franky47
Loading

See #794.

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:02am

@vercel Vercel
Copy link

vercel bot commented Dec 7, 2024

@sebastianvitterso is attempting to deploy a commit to the 47ng Team on Vercel.

A member of the Team first needs to authorize it.

franky47
franky47 approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@franky47 franky47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this could even be added at the top before each testing framework's example, to introduce the concept of the withNuqsTestingAdapter factory function beforehand.

@franky47 franky47 added this to the 🪵 Backlog milestone Dec 7, 2024
@franky47 franky47 added the documentation Improvements or additions to documentation label Dec 7, 2024
@sebastianvitterso
Copy link
Contributor Author

I've allowed edits by maintainers, so feel free to adjust the ordering of the document!

@franky47 franky47 force-pushed the docs/document-nuqs-hooks-testing branch from 8a605bd to d532536 Compare December 10, 2024 09:34
@sebastianvitterso
Copy link
Contributor Author

I guess you'll merge when you want ✌️

@franky47 franky47 changed the title docs: document testing nuqs based hooks docs: Document testing nuqs based hooks Dec 10, 2024
@franky47 franky47 merged commit 96239ee into 47ng:next Dec 10, 2024
27 checks passed
@sebastianvitterso sebastianvitterso deleted the docs/document-nuqs-hooks-testing branch December 10, 2024 10:52
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@franky47 franky47 mentioned this pull request Jan 3, 2025
Open
@franky47 franky47 removed this from the 🚀 Shipping next milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franky47 franky47 franky47 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianvitterso @franky47