Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move e2e tests into shared library #807

Merged
merged 20 commits into from
Dec 15, 2024
Merged

Conversation

franky47
Copy link
Member

@franky47 franky47 commented Dec 13, 2024

There are core behaviours of the library that should behave the same for each framework, so we can make a shared library that contains the fixture components and spec files that test them, and consume those in each of the Cypress E2E setups.

  • Basic I/O
  • Hash preservation
  • Push
  • Linking
  • Routing (imperative calls)
  • Shallow (where applicable)
  • Scroll restoration

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2024 8:22pm

Copy link

pkg-pr-new bot commented Dec 13, 2024

Open in Stackblitz

npm i https://pkg.pr.new/nuqs@807

commit: 4ed557c

@franky47 franky47 marked this pull request as ready for review December 15, 2024 20:22
@franky47 franky47 merged commit 54067b3 into next Dec 15, 2024
25 checks passed
@franky47 franky47 deleted the test/e2e-behaviour-library branch December 15, 2024 20:30
Copy link

🎉 This PR is included in version 2.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jan 1, 2025

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@franky47 franky47 mentioned this pull request Jan 3, 2025
@franky47 franky47 removed this from the 🚀 Shipping next milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant