Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add native HTML form test #829

Merged
merged 4 commits into from
Dec 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions packages/e2e/next/cypress/e2e/shared/form.cy.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { testForm } from 'e2e-shared/specs/form.cy'

testForm({
path: '/app/form/useQueryState',
hook: 'useQueryState',
nextJsRouter: 'app'
})

testForm({
path: '/app/form/useQueryStates',
hook: 'useQueryStates',
nextJsRouter: 'app'
})

testForm({
path: '/pages/form/useQueryState',
hook: 'useQueryState',
nextJsRouter: 'pages'
})

testForm({
path: '/pages/form/useQueryStates',
hook: 'useQueryStates',
nextJsRouter: 'pages'
})
10 changes: 10 additions & 0 deletions packages/e2e/next/src/app/app/(shared)/form/useQueryState/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { TestFormUseQueryState } from 'e2e-shared/specs/form'
import { Suspense } from 'react'

export default function Page() {
return (
<Suspense>
<TestFormUseQueryState />
</Suspense>
)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { TestFormUseQueryStates } from 'e2e-shared/specs/form'
import { Suspense } from 'react'

export default function Page() {
return (
<Suspense>
<TestFormUseQueryStates />
</Suspense>
)
}
3 changes: 3 additions & 0 deletions packages/e2e/next/src/pages/pages/form/useQueryState.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryState } from 'e2e-shared/specs/form'

export default TestFormUseQueryState
3 changes: 3 additions & 0 deletions packages/e2e/next/src/pages/pages/form/useQueryStates.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryStates } from 'e2e-shared/specs/form'

export default TestFormUseQueryStates
11 changes: 11 additions & 0 deletions packages/e2e/react-router/v6/cypress/e2e/shared/form.cy.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { testForm } from 'e2e-shared/specs/form.cy'

testForm({
path: '/form/useQueryState',
hook: 'useQueryState'
})

testForm({
path: '/form/useQueryStates',
hook: 'useQueryStates'
})
2 changes: 2 additions & 0 deletions packages/e2e/react-router/v6/src/react-router.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ const router = createBrowserRouter(
<Route path='shallow/useQueryState' lazy={load(import('./routes/shallow.useQueryState'))} />
<Route path='shallow/useQueryStates' lazy={load(import('./routes/shallow.useQueryStates'))} />
<Route path='loader' lazy={load(import('./routes/loader'))} />
<Route path="form/useQueryState" lazy={load(import('./routes/form.useQueryState'))} />
<Route path="form/useQueryStates" lazy={load(import('./routes/form.useQueryStates'))} />
</Route>
))

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryState } from 'e2e-shared/specs/form'

export default TestFormUseQueryState
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryStates } from 'e2e-shared/specs/form'

export default TestFormUseQueryStates
4 changes: 3 additions & 1 deletion packages/e2e/react-router/v7/app/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ export default [
route('/routing/useQueryStates/other', './routes/routing.useQueryStates.other.tsx'),
route('/shallow/useQueryState', './routes/shallow.useQueryState.tsx'),
route('/shallow/useQueryStates', './routes/shallow.useQueryStates.tsx'),
route('/loader', './routes/loader.tsx')
route('/loader', './routes/loader.tsx'),
route('/form/useQueryState', './routes/form.useQueryState.tsx'),
route('/form/useQueryStates', './routes/form.useQueryStates.tsx'),
])
] satisfies RouteConfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryState } from 'e2e-shared/specs/form'

export default TestFormUseQueryState
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryStates } from 'e2e-shared/specs/form'

export default TestFormUseQueryStates
11 changes: 11 additions & 0 deletions packages/e2e/react-router/v7/cypress/e2e/shared/form.cy.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { testForm } from 'e2e-shared/specs/form.cy'

testForm({
path: '/form/useQueryState',
hook: 'useQueryState'
})

testForm({
path: '/form/useQueryStates',
hook: 'useQueryStates'
})
11 changes: 11 additions & 0 deletions packages/e2e/react/cypress/e2e/shared/form.cy.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { testForm } from 'e2e-shared/specs/form.cy'

testForm({
path: '/form/useQueryState',
hook: 'useQueryState'
})

testForm({
path: '/form/useQueryStates',
hook: 'useQueryStates'
})
2 changes: 2 additions & 0 deletions packages/e2e/react/src/routes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ const routes: Record<string, React.LazyExoticComponent<() => JSX.Element>> = {
'/routing/useQueryStates/other': lazy(() => import('./routes/routing.useQueryStates.other')),
'/shallow/useQueryState': lazy(() => import('./routes/shallow.useQueryState')),
'/shallow/useQueryStates': lazy(() => import('./routes/shallow.useQueryStates')),
'/form/useQueryState': lazy(() => import('./routes/form.useQueryState')),
'/form/useQueryStates': lazy(() => import('./routes/form.useQueryStates')),
}

export function Router() {
Expand Down
3 changes: 3 additions & 0 deletions packages/e2e/react/src/routes/form.useQueryState.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryState } from 'e2e-shared/specs/form'

export default TestFormUseQueryState
3 changes: 3 additions & 0 deletions packages/e2e/react/src/routes/form.useQueryStates.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryStates } from 'e2e-shared/specs/form'

export default TestFormUseQueryStates
3 changes: 3 additions & 0 deletions packages/e2e/remix/app/routes/form.useQueryState.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryState } from 'e2e-shared/specs/form'

export default TestFormUseQueryState
3 changes: 3 additions & 0 deletions packages/e2e/remix/app/routes/form.useQueryStates.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { TestFormUseQueryStates } from 'e2e-shared/specs/form'

export default TestFormUseQueryStates
11 changes: 11 additions & 0 deletions packages/e2e/remix/cypress/e2e/shared/form.cy.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { testForm } from 'e2e-shared/specs/form.cy'

testForm({
path: '/form/useQueryState',
hook: 'useQueryState'
})

testForm({
path: '/form/useQueryStates',
hook: 'useQueryStates'
})
25 changes: 25 additions & 0 deletions packages/e2e/shared/specs/form.cy.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { createTest } from '../create-test'

export const testForm = createTest('Form', ({ path }) => {
it('supports native HTML forms to update search params', () => {
cy.visit(path)
cy.contains('#hydration-marker', 'hydrated').should('be.hidden')
cy.get('input').type('pass')
cy.get('form').submit()
cy.get('#state').should('have.text', 'pass')
cy.go('back')
cy.get('#state').should('have.text', '')
})

it('supports loading initial form state from the URL', () => {
cy.visit(path + '?test=init')
cy.contains('#hydration-marker', 'hydrated').should('be.hidden')
cy.get('input').should('have.value', 'init')
cy.get('#state').should('have.text', 'init')
cy.get('input').clear().type('pass')
cy.get('form').submit()
cy.get('#state').should('have.text', 'pass')
cy.go('back')
cy.get('#state').should('have.text', 'init')
})
})
47 changes: 47 additions & 0 deletions packages/e2e/shared/specs/form.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
'use client'

import { parseAsString, useQueryState, useQueryStates } from 'nuqs'

type FormProps = {
defaultValue: string
}

const testParser = parseAsString.withDefault('')

function Form({ defaultValue }: FormProps) {
return (
<form>
<input type="text" id="test" name="test" defaultValue={defaultValue} />
<button type="submit">Submit</button>
</form>
)
}

export function TestFormUseQueryState() {
const [state] = useQueryState('test', testParser)
return (
<>
<pre id="state">{state}</pre>
<Form defaultValue={state} />
</>
)
}

export function TestFormUseQueryStates() {
const [{ state }] = useQueryStates(
{
state: testParser
},
{
urlKeys: {
state: 'test'
}
}
)
return (
<>
<pre id="state">{state}</pre>
<Form defaultValue={state} />
</>
)
}