Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test a theory for RR sync #830

Closed
wants to merge 6 commits into from
Closed

chore: Test a theory for RR sync #830

wants to merge 6 commits into from

Conversation

franky47
Copy link
Member

@franky47 franky47 commented Dec 29, 2024

There may be some extra renders being caused by two hooks emitting the same sync event due to parallel effects running.

Edit: coding on a phone is not the best DX..

Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuqs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 9:56pm

Copy link

pkg-pr-new bot commented Dec 29, 2024

Open in Stackblitz

npm i https://pkg.pr.new/nuqs@830

commit: f2e6052

@franky47
Copy link
Member Author

franky47 commented Dec 31, 2024

I found that patching history is needed to follow Links in React Router frameworks. So it's going to be enabled by default (and not exported). I'll close this PR and cherry pick the relevant parts in a more focused, better documented PR.

Edit: superseded by #833.

@franky47 franky47 closed this Dec 31, 2024
@franky47 franky47 removed this from the 🪵 Backlog milestone Dec 31, 2024
@franky47 franky47 deleted the franky47-patch-1 branch December 31, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant