Ability to determine PR number on workflow_run events associated with fork repository PRs. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forks gets a read-only token. This causes the workflows involving `cobertura-action` fail, due to lack of permission. > `Error: Resource not accessible by integration Actions team recently introduced `pull_request_target`, but that pose additional security risks. To mitigate that, they recommend to split these workflows, a well-written recipe can be found in 5monkeys#2 Certainly, `cobertura-action` accepts `pull_request_number` parameter, but that will put the onus on the workflow author. So, inorder to keep things simple, this PR adds functionality to determine correctly the PR number on `workflow_run` events. References: - 1 https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/ - 2 https://securitylab.github.com/research/github-actions-preventing-pwn-requests
…forks gets a read-only token. This causes the workflows involving `cobertura-action` fail, due to lack of permission. > `Error: Resource not accessible by integration Actions team recently introduced `pull_request_target`, but that pose additional security risks. To mitigate that, they recommend to split these workflows, a well-written recipe can be found in 5monkeys#2 Certainly, `cobertura-action` accepts `pull_request_number` parameter, but that will put the onus on the workflow author. So, inorder to keep things simple, this PR adds functionality to determine correctly the PR number on `workflow_run` events. References: - 1 https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/ - 2 https://securitylab.github.com/research/github-actions-preventing-pwn-requests
|
Ironically this PR is failing due to exact same reason. Like the recipe in https://securitylab.github.com/research/github-actions-preventing-pwn-requests, we might have to split the workflow, to get these sort of PRs to pass. |
6 tasks
hannseman
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution for issue #27.
So,
pull_request_numberis not provided, it will check to see if the workflow is triggered due to a pull request associated withworkflow_runevent and appropriately determines the PR number.