Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floor percentages #44

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Floor percentages #44

merged 3 commits into from
Jun 11, 2021

Conversation

antonagestam
Copy link
Contributor

Changes to round percentages down so that 99.99 ≠ 100.

@github-actions
Copy link

github-actions bot commented May 27, 2021 •
edited
Loading

File Coverage
All files 100% ✅

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 0d9cd46

hannseman
hannseman approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@hannseman hannseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@hannseman
Copy link
Contributor

@antonagestam could you run npm run package in this PR?

@antonagestam
Copy link
Contributor Author

@hannseman I finally got around to compiling :)

@antonagestam
Copy link
Contributor Author

Hmm, but this failed: https://github.com/5monkeys/cobertura-action/runs/2803370740?check_suite_focus=true

@hannseman
Copy link
Contributor

@antonagestam looks like something went wrong with the packaging, 16k deletions in dist/index.js. I get this output when building this PR:

$ npm run package

> [email protected] package
> ncc build index.js

ncc: Version 0.22.3
ncc: Compiling file index.js
478kB  dist/index.js
478kB  [1201ms] - ncc 0.22.3

Can you try removing node_modules and run npm ci first?

@hannseman hannseman merged commit 7b96dd4 into 5monkeys:master Jun 11, 2021
@antonagestam antonagestam deleted the fix/floor-percentages branch September 1, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannseman hannseman hannseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonagestam @hannseman