Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a check with code coverage report: #50

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

tspascoal
Copy link
Contributor

Adds a check with code coverage report:

  • With a check it's possible to always see the code coverage results regardless of the workflow event type
  • Code Coverage threshold status is always reported on the check regardless of fail_below_threshold setting. This allows setting branch protection checks regardless of workflow status
  • supports push event as well

No longer fails workflow if PR cannot be determined.

- With a check it's possible to always see the code coverage results regardless  of the workflow event type
- Code Coverage threshold status is always reported on the check regardless of `fail_below_threshold` setting. This allows setting branch protection checks regardless of workflow status
- supports push event as well

No longer fails workflow if PR cannot be determined.
Copy link
Contributor

@hannseman hannseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks for the PR and sorry for the late reply.

@hannseman
Copy link
Contributor

@tspascoal FYI, I had to move the else if (payload.after) check to be after the else if (payload.pull_request) check. Otherwise no comment would be added to the PR:s. See: #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants