Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying source dir for missing line links #59

Conversation

antonagestam
Copy link
Contributor

I looked into the cobertura XML file, and it does have <sources>, but I think it will be hard to use that since at least when using coveragepy the resulting source path is an absolute path. From our docker build the generated path is "/app/src":

<sources>
    <source>/app/src</source>
</sources>

It seemed easy enough to support a config option instead.

@github-actions
Copy link

github-actions bot commented Nov 27, 2021

File Coverage
All files 100%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against f9ae411

Copy link
Contributor

@hannseman hannseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action.yml needs to be updated with the new option.

Copy link
Contributor

@hannseman hannseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Najs!

@antonagestam antonagestam merged commit 47d3d6f into 5monkeys:master Nov 30, 2021
@antonagestam antonagestam deleted the feature/link-missing-lines-source-dir branch November 30, 2021 10:58
kevinvalk added a commit to kevinvalk/cobertura-action that referenced this pull request Sep 8, 2022
kevinvalk added a commit to kevinvalk/cobertura-action that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants