Add type hints #70
Merged
Add type hints #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 699ff12 |
antonagestam
commented
Oct 14, 2021
bananas/__init__.py
Outdated
| @@ -1,25 +1,23 @@ | |||
| VERSION = (2, 0, 0, "final", 0) | |||
|
|
|||
|
|
|||
| def get_version(version=None): | |||
| def get_version() -> str: | |||
There was a problem hiding this comment.
Felt unnecessary to implement types for version: Union[VersionTuple, str, None] here instead of just dropping the version argument and always use VERSION.
antonagestam
commented
Oct 14, 2021
bananas/models.py
Outdated
Comment on lines
15
to
19
| class Missing: | ||
| ... | ||
|
|
||
| class ModelDict(dict): | ||
|
|
||
| _nested = None | ||
| MISSING: Final = Missing() |
There was a problem hiding this comment.
It's impossible to narrow the type of MISSING: Final = object(), hence introducing a type here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bananas.__init__show_urlscommandsyncpermissionscommandbananas.modelsRemaining untyped after this PR is
bananas.adminandbananas.query.I started working on
bananas.querytoo, but that it'll take some amount of work to finish and gets very involved (probably impossible to achieve an acceptable level of typing without importing types from django-stubs, guarded byif TYPE_CHECKING.