-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding initialPageParam and nested nextPageParam support #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
If you don't mind documenting the change in the readme that would be awesome. Thanks.
I've combined my two PRs into this one to prevent having to rebase and re-generate the snapshots between merges. I've also added docs as requested. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the awesome PR! It looks great!
@adamgoose @7nohe this caused a breaking change, if you dont provide the |
This adds a new argument
--initialPageParam
to customize theinitialPageParam
option passed to useInfiniteQuery. Defaults to 1.Fixes #141.
When nextPageParam is set to meta.nextPage, split on . and generate the appropriately nested typehint:
Fixes #142.