Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHALLENGE_DOMAIN should be used when add TXT dns #2

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

tongyifan
Copy link
Contributor

用中文没问题吧2333

如果像之前那样 name: _acme-challenge ,会为_acme-challenge.example.com创建一个TXT记录,这个方式使用主域名是没问题的,但是如果给二级域名test.example.com申请证书时,要求创建的是_acme-challenge.test.example.com,这样就通过不了了。
因此就改了一下,直接使用CHALLENGE_DOMAIN,试了一下cloudflare是能正常识别出最后的主域名并生成正确的记录的。

用中文没问题吧2333

如果像之前那样 `name: _acme-challenge` ,会为_acme-challenge.example.com创建一个TXT记录,这个方式使用主域名是没问题的,但是如果给二级域名test.example.com申请证书时,要求创建的是_acme-challenge.test.example.com,这样就通过不了了。
因此就改了一下,直接使用CHALLENGE_DOMAIN,试了一下cloudflare是能正常识别出最后的主域名并生成正确的记录的。
@tongyifan
Copy link
Contributor Author

啊似乎存在一些问题,稍等我改一下

@tongyifan
Copy link
Contributor Author

啊似乎存在一些问题,稍等我改一下

= =是测试的机子忘了装dig,没什么问题

@7sDream
Copy link
Owner

7sDream commented Nov 20, 2019

嗷~

正如 README 里写的:

Simple scripts I use to auto renew my Let's encrypt wildcard SSL cert.

我是直接申请 example.com*.example.com 通配证书的,没测过申请二级域名的情况。

不过也确实该用变量,看着没啥问题,合了合了。

@7sDream 7sDream merged commit 56d688f into 7sDream:master Nov 20, 2019
pjrobertson added a commit to pjrobertson/certbot-dns-challenge-cloudflare-hooks that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants