Kitiya: TDD Kata 3 - Password Verifier

[kitiya]

Thank you very much for the presentation on Friday and providing us this code challenge. I've learned some new topics by working on this exercise. Thanks in advance for your feedback and please let me know if you have any questions.

[kitiya]

To be safe, I changed the if statement to return true when (numValid >=3)

[raulchedrese]

Nice work 👍 I'd encourage you to take a look at some of the other submissions and the comments as well.

[raulchedrese]

Nice tests. I this case I would consider only testing the verify method. You could test all these things through that method and then you could make the specific checks private.

[raulchedrese]

I'm not convinced that you should be returning anything in these methods. I find it confusing. These methods will either throw an exception or return true so if no exception is thrown we can assume all went well instead of having to check for return values and exceptions.

public boolean containsUppercase(String password) throws IllegalArgumentException {
    Pattern uppercasePattern = Pattern.compile("^(?=.*[A-Z]).+$");
    Boolean isValidPassword = (password != null) && uppercasePattern.matcher(password).matches();

    if (!isValidPassword)
        throw new IllegalArgumentException("Password should have at least one uppercase letter.");
}

[raulchedrese]

All these try catch statements do the same thing. Can we simplify to something like:

try {
    if (!containsLowercase(password)) return false
    numValid++
    if (isNotNull(password)) numValid++;
    if (isLargerThanEight(password)) numValid++;
    if (numValid >= 3) return true; // for optimization
    if (containsUppercase(password)) numValid ++;
    if (numValid >= 3) return true; // for optimization
    if (containsDigit(password)) numValid ++;
} catch (IllegalArgumentException e) {
    System.out.println(e);
}