-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate getters for interface fields #2314
Generate getters for interface fields #2314
Conversation
I see a lot of the checks failing. Didn’t realize quite how many tests there were throughout the codebase. Are any safe to ignore, or should I go into each and make sure they all pass? |
There is some issue with the template, you need to fix all issues.
|
The lint step is failing because of a generated code diff. No matter how I try to run EDIT: In case it's relevant, running Windows 10 64-bit, Go 1.19 |
So the generated code comment has either one or two leading spaces depending on Go 1.18 vs Go 1.19:
Which originates from the GraphQL schema comment:
Not sure what is different, but that's probably a separate issue from this PR, so it's ok to have manually fudged it here. |
Please see #2331 |
Closes #1469
The Star Wars example has a small hack in it (GetFriendsConnection / GetFriends) due to the custom resolver logic. That may need looked at, since it's no longer a very clear cut example