Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag as v1.0.0 #49

Closed
nickatsegment opened this issue Jul 2, 2019 · 2 comments
Closed

Tag as v1.0.0 #49

nickatsegment opened this issue Jul 2, 2019 · 2 comments

Comments

@nickatsegment
Copy link

The current tag 1.0.0 isn't recognized by go modules; you need a v prefix. Without v it basically just ignores the tag and we're back to SHA refs.

Related: #24
@akerl
Copy link

akerl commented Jul 4, 2019

I guess more specifically, I’d recommend tagging current master as v1.0.1 :D

@mtibben
Copy link
Member

mtibben commented Jul 12, 2019

Fixed

@mtibben mtibben closed this as completed Jul 12, 2019
nickatsegment added a commit to segmentio/aws-okta that referenced this issue Jul 15, 2019
@nickatsegment
Upstream added a go-mod-compatible tag v1.0.0
6b1d0fd 
99designs/keyring#49
@nickatsegment nickatsegment mentioned this issue Jul 15, 2019
Merged
nickatsegment added a commit to segmentio/aws-okta that referenced this issue Jul 23, 2019
@nickatsegment
Upstream added a go-mod-compatible tag v1.0.0 (#180)
bfe0916 
99designs/keyring#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akerl @mtibben @nickatsegment