Offers without extra plugin #2976
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomash-acinq
force-pushed
the
offers-no-plugin
branch
2 times, most recently
from
b8611f6 to
5e9bc0e
Compare
When using blinded payment paths, the fees of the blinded path should be paid by the recipient, not the sender. - It is more fair: the sender chooses the non blinded part of the path and pays the corresponding fees, the recipient chooses the blinded part of the path and pays the corresponding fees. - It is more private: the sender does not learn the actual fees for the path and can't use this information to unblind the path.
thomash-acinq
force-pushed
the
offers-no-plugin
branch
2 times, most recently
from
3950baf to
fbd66d6
Compare
thomash-acinq
force-pushed
the
offers-no-plugin
branch
2 times, most recently
from
cb4e211 to
467a5a4
Compare
thomash-acinq
force-pushed
the
offers-no-plugin
branch
from
467a5a4 to
665ad0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable basic offer management without the need for a plugin.
Offers allow a wide range of use-cases and it would be impossible to cover everything in eclair which is why we have relied on plugins to manage offers. However most users will not need advanced features, with this PR we aim to provide the basic features that will be enough for 95% of users. Advanced users can still use a plugin to manage more complex offers.
Supported use-cases: