Simplify and improve typing in NodeParams
#603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all unused parameters, and proper type for durations.
Connecting can be quite long with Tor.
pm47
commented
Feb 15, 2024
pm47
commented
Feb 15, 2024
sstone
approved these changes
Feb 15, 2024
dpad85
added a commit
to ACINQ/phoenix
that referenced
this pull request
Feb 20, 2024
- Either, Try, Chain are now provided by bitcoin-kmp - NodeParams has been simplified - Added a new Bolt12Invoice type; PaymentRequest is an interface. See: ACINQ/lightning-kmp#590 ACINQ/lightning-kmp#603 ACINQ/lightning-kmp#605
dpad85
added a commit
to ACINQ/phoenix
that referenced
this pull request
Feb 22, 2024
Phoenix now uses lightning-kmp 1.6.1, with support for taproot addresses and address rotation, improving privacy and making swap transactions slightly cheaper. The swap-in wallet now exposes a flow containing the current address, and a flow of addresses that have already been used (plus the current unused address, and a static native segwit address). Future unused addresses are not exposed. Swaps to the legacy address will still work, however usage should be discouraged. By default, we use taproot addresses. The swap-in model/intent has been removed from the shared ReceiveController. Since the swap-in wallet may take time to synchronize all used addresses at startup, the app stores the last known unused index in its preferences, and uses that index when the app starts to display an address while synchronising. There's a small risk of address reuse at startup. Some maintenance work has also been made. With lightning- kmp version 1.6, several APIs have changed: - Either, Try, Chain are now provided by bitcoin-kmp - NodeParams has been simplified - Added a new Bolt12Invoice type; PaymentRequest is an interface. See: ACINQ/lightning-kmp#590 ACINQ/lightning-kmp#603 ACINQ/lightning-kmp#605 --------- Co-authored-by: Robbie Hanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all unused parameters, and use proper type for durations.
Also, increase
checkHtlcTimeoutAfterStartupDelayto 30s as connecting can be quite long with Tor.