-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libafl_bolts: rands
super mega ultra giga house cleaning of doom
#2123
Conversation
bff641f
to
961356c
Compare
Do we really want to remove working rngs? |
I've written the rationale in the commit message. This is a controversial thing, for sure, I can leave them in if you prefer. My idea was to leave only some kind of "Pareto frontier" of generators, with |
Instead of removing RNGs, please mark them with Part of the reason for LibAFL's existence is not just to have good perf all the time, but to have the best performance for the given task. Suppose someone comes along and wants to evaluate the actual effects of low entropy random in fuzzing; it is totally legitimate for them to select "bad" RNGs. This is a bit of a contrived example, of course, but this is also relevant for e.g. reproduction works and avoiding breaking user code where possible/reasonable. |
All PRNGs are back in! I decided not to deprecate anything in this PR -- this can be done separately. |
Thank you! :) |
@flyingmutant Can you add an issue to deprecate these RNGs? Don't want to forget to do so. |
Fixes #2101.