Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Use* from stages #2745

Merged
merged 11 commits into from
Dec 12, 2024
Merged

No Use* from stages #2745

merged 11 commits into from
Dec 12, 2024

Conversation

tokatoka
Copy link
Member

@tokatoka tokatoka commented Dec 5, 2024

No description provided.

@tokatoka
Copy link
Member Author

tokatoka commented Dec 5, 2024

It was impossible to remove some of UsesState because trait such as ExecutionProcess or EventFirer really needs it.

@tokatoka
Copy link
Member Author

tokatoka commented Dec 5, 2024

but events is heavily dependent on fuzzer and fuzzer is dependent on stage
so i could only start from here.

only after this can i touch other modules

@domenukk
Copy link
Member

domenukk commented Dec 6, 2024

Still some way to go

error[E0107]: trait takes 4 generic arguments but 3 generic arguments were supplied
  --> libafl_targets/src/cmps/stages/aflpptracing.rs:51:20
   |
51 | impl<E, EM, TE, Z> Stage<E, EM, Z> for AFLppCmplogTracingStage<'_, EM, TE, Z>
   |                    ^^^^^ -  --  - supplied 3 generic arguments
   |                    |
   |                    expected 4 generic arguments
   |

@domenukk
Copy link
Member

domenukk commented Dec 6, 2024

Also, it's a bit sad we get more generics this way? Wasn't it the point of Uses* to get rid of some? I guess I asked this same question for every PR :D

@tokatoka
Copy link
Member Author

tokatoka commented Dec 6, 2024

it's a bit sad we get more generics this way?

it could be so because trait State has been changed with smaller sets of contraints,
and it could look so because for now i cannot completely remove UsesState while EventManager, Executor ... still use them

@domenukk
Copy link
Member

domenukk commented Dec 6, 2024

If you think over time we'll reduce generics I'm happy

@tokatoka
Copy link
Member Author

tokatoka commented Dec 6, 2024

everytime i make pr i have more deletion than addition so it's fine

P: MutationalStage<E, EM, I, M, Z, State = S>,
S: State<Input = I> + HasRand + HasCorpus + HasNamedMetadata,
<<Self as UsesState>::State as HasCorpus>::Corpus: Corpus<Input = Self::Input>, //delete me
SM: MutationalStage<M, S>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! <3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better

@tokatoka
Copy link
Member Author

it's a bit sad we get more generics this way?

regarding, this
we will have more generics but less traits bounds

@tokatoka tokatoka merged commit 3446ad9 into main Dec 12, 2024
103 checks passed
@tokatoka tokatoka deleted the no_uses_fuzzer branch December 12, 2024 15:50
riesentoaster pushed a commit to riesentoaster/LibAFL that referenced this pull request Dec 15, 2024
* no from stage

* fixer

* doc fix

* how was this working????

* more fixes

* delete more

* rq

* cargo-fuzz

* m

* aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants