-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Use* from stages #2745
No Use* from stages #2745
Conversation
It was impossible to remove some of UsesState because trait such as ExecutionProcess or EventFirer really needs it. |
but events is heavily dependent on fuzzer and fuzzer is dependent on stage only after this can i touch other modules |
Still some way to go error[E0107]: trait takes 4 generic arguments but 3 generic arguments were supplied
--> libafl_targets/src/cmps/stages/aflpptracing.rs:51:20
|
51 | impl<E, EM, TE, Z> Stage<E, EM, Z> for AFLppCmplogTracingStage<'_, EM, TE, Z>
| ^^^^^ - -- - supplied 3 generic arguments
| |
| expected 4 generic arguments
| |
Also, it's a bit sad we get more generics this way? Wasn't it the point of Uses* to get rid of some? I guess I asked this same question for every PR :D |
it could be so because trait |
If you think over time we'll reduce generics I'm happy |
everytime i make pr i have more deletion than addition so it's fine |
P: MutationalStage<E, EM, I, M, Z, State = S>, | ||
S: State<Input = I> + HasRand + HasCorpus + HasNamedMetadata, | ||
<<Self as UsesState>::State as HasCorpus>::Corpus: Corpus<Input = Self::Input>, //delete me | ||
SM: MutationalStage<M, S>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! <3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot better
regarding, this |
* no from stage * fixer * doc fix * how was this working???? * more fixes * delete more * rq * cargo-fuzz * m * aa
No description provided.