Intel PT minor fixes and improvements #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create target directory if doesn't exist
since also committed blocks can have this flag
domenukk
reviewed
Dec 6, 2024
| @@ -37,6 +37,8 @@ pub fn main() { | |||
| env_logger::init(); | |||
|
|
|||
| let target_path = PathBuf::from(env::args().next().unwrap()) | |||
| .parent() | |||
There was a problem hiding this comment.
Maybe add a comment what this is doing?
There was a problem hiding this comment.
yeah, clearer now?
There was a problem hiding this comment.
It's not super clear why this is two parents up, but good enough :D
riesentoaster
pushed a commit
to riesentoaster/LibAFL
that referenced
this pull request
Dec 11, 2024
* Fix build target Create target directory if doesn't exist * Remove filter on speculatively exec blocks since also committed blocks can have this flag * Add current ip_filters getter * Fix possibile infinite loop in trace decode * Add comment about target_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.