Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup clippy warnings in example fuzzers #2770

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Cleanup clippy warnings in example fuzzers #2770

wants to merge 4 commits into from
+7 −4

Conversation

mzfr
Copy link

@mzfr mzfr commented Dec 15, 2024

Addresses #1907

domenukk
domenukk reviewed Dec 15, 2024
View reviewed changes
fuzzers/fuzz_anything/baby_no_std/src/main.rs
@@ -48,6 +48,7 @@ fn panic(_info: &PanicInfo) -> ! {

/// Coverage map with explicit assignments due to the lack of instrumentation
static mut SIGNALS: [u8; 16] = [0; 16];
#[allow(static_mut_refs)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to not use static_mut_refs.
Ideally we should use this function instead to create the observer:

LibAFL/fuzzers/structure_aware/baby_fuzzer_multi/src/main.rs

Line 85 in 5324799

unsafe { ConstMapObserver::from_mut_ptr("signals", nonnull_raw_mut!(SIGNALS)) };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenukk domenukk domenukk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzfr @domenukk