130 allow users to share charts #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikestone14
reviewed
Aug 16, 2022
mikestone14
reviewed
Aug 16, 2022
mikestone14
reviewed
Aug 16, 2022
views/components/ChartList.jsx
Outdated
Comment on lines
62
to
63
| const { data } = await getCharts() | ||
| setChartList(data) |
There was a problem hiding this comment.
why do we need to get charts after we share a chart?
There was a problem hiding this comment.
We render the sharedWith list when we open the shareChart dialog component, calling the getCharts api we have the latest available data to display.
views/components/ShareCharts.jsx
Outdated
| <Button | ||
| onClick={closeDialog} | ||
| style={{ | ||
| color: '#5790bd', |
There was a problem hiding this comment.
can these color strings be stored as constants somewhere?
This commit: * Replicates the configuration share feature for charts, allowing users to share charts with other users. * Adds a new attribute, sharedWith, to charts which contains an array of usernames of other users that the chart is shared with.
Elkrival
force-pushed
the
130-allow-users-to-share-charts
branch
from
d26c11b to
d814fdd
Compare
mikestone14
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to share charts
FE
BE
Video of functionality