Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

original SDC implementation Jacobian is not correct #147

Closed
zingale opened this issue Aug 26, 2018 · 2 comments
Closed

original SDC implementation Jacobian is not correct #147

zingale opened this issue Aug 26, 2018 · 2 comments
Assignees

Comments

@zingale
Copy link
Member

zingale commented Aug 26, 2018

The analytic Jacobian for the original SDC (enabled by setting the SDC preprocessor) is not correct. The Jacobian elements should be derivatives with respect to the conserved variables. The proper way to do this is to construct a second transformation Jacobian, d(rho, rho X, rho E)/d(rho, T, X) and use this to transform the derivatives that come from the burner. This is actually quite easy, and is implemented in the new SDC implementation in the sdc branch of Castro.

With the analytic Jacobian enabled (jacobian=1), this original SDC method surprisingly runs, but very slowly.

@dwillcox dwillcox self-assigned this Oct 25, 2018
@zingale
Copy link
Member Author

zingale commented Mar 3, 2019

At the moment, our state vector that the ODE integration sees is (rho X, rho E, rho e). We get the Jacobian from the net in terms of rho, T, X. I think in order to do the transformation properly, we should integrate only one of (rho E) or (rho e), and add rho to the ODE integration vector. Then we can do the same transformation as we are doing in the new SDC stuff.

@zingale
Copy link
Member Author

zingale commented Nov 16, 2019

It looks like the function that needs to be modified is jac_to_vode in vode_type_simplified_sdc.F90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants