-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the Jacobian for the simplified-SDC system #228
Conversation
this won't even come close to compiling
stil lneed to do the enthalpy system
this will close #147 still need to do the MAESTROeX / enthalpy part |
This now works for both the energy and enthalpy-based SDC formulations. |
The energy based Jacobian derivation is here: simplified_sdc_derivations.pdf The enthalpy based Jacobian derivation is here: |
For the
and with the analytic Jacobian we get:
The speed-up is the same when considering the enthalpy system. On
so this change is definitely a win. |
I think that this is ready to be reviewed. Here's an updated derivation of the system used for energy. |
Castro detonation tests, running for 250 steps.
|
For simplified SDC we need to convert from the reaction system Jacobian (in terms of X, T, e) to the system for the conserved variables. This does that transformation.