Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have clang-tidy warn about recursion #1532

Merged
merged 1 commit into from
Apr 10, 2024
Merged

have clang-tidy warn about recursion #1532

merged 1 commit into from
Apr 10, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 9, 2024

CUDA doesn't seem to like it

@zingale
have clang-tidy warn about recursion
778f5b0 
CUDA doesn't seem to like it
yut23
yut23 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@yut23 yut23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

factorial() from rhs.H comes up in the report, but it's only ever called at compile-time.

@zingale zingale merged commit 983c8e6 into AMReX-Astro:development Apr 10, 2024
28 checks passed
@zingale zingale deleted the recursion branch April 10, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23