Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert polytrope to C++ #264

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Convert polytrope to C++ #264

merged 1 commit into from
Feb 23, 2020

Conversation

maxpkatz
Copy link
Member

No description provided.

@zingale
Copy link
Member

zingale commented Feb 23, 2020

test_eos and test_eos_C agree for the F90 and C++ EOS on all vars except:

 n_e                               0.1000000000E-98          0.1000000000E+99
 n_p                               0.1000000000E-98           1.000000000    
 eta                               0.1000000000E-98           1.000000000    
 p_ele                             0.1000000000E-98           100.7282204    
 p_pos                             0.1000000000E-98          0.4071649222E+11
 mu                                0.1000000000E-98          0.4397706474E+13

those are simply not set.

@zingale zingale merged commit b433808 into development Feb 23, 2020
@zingale zingale deleted the cxx-polytrope branch February 23, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxpkatz @zingale