Move iso7 to C++ #303
Merged
Move iso7 to C++ #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors after calling screening_init()...
…and introduce some math.
…yNDs into ArrayUtil::RealArrayND.
maxpkatz
reviewed
Apr 14, 2020
maxpkatz
reviewed
Apr 14, 2020
networks/iso7/actual_rhs.H
Outdated
| using namespace Rates; | ||
|
|
||
| { | ||
| Array1D<Real, 1, 8> b; |
There was a problem hiding this comment.
In the Fortran what we were doing here is reusing the same array and relying on the fact that esumN ever uses more than N elements of the array. I don't have any problem with this way of writing it, as long as the compiler figures out that it can reuse the registers under the hood.
There was a problem hiding this comment.
yes, hopefully so with the {} scoping
it's easy enough to make the esums take arbitrary sized Array1Ds if we need
maxpkatz
reviewed
Apr 14, 2020
this will be used if compiling with `USE_NETWORK_SOLVER=TRUE`
…etwork_properties header
zingale
approved these changes
Apr 15, 2020
Merged
maxpkatz
pushed a commit
that referenced
this pull request
Apr 17, 2020
This PR ports aprox13 to C++ using the same strategy as for iso7 in #303. This PR also adds input files for test_rhs for aprox13 based on test_react inputs, except with call_eos_in_rhs=T. To avoid completely refactoring the rhs in aprox13, passing arbitrary size Array1D arrays to all esum functions is now enabled by making esums templated functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the iso7 network to C++ as well as other parts of Microphysics the network depends on.
This includes a C++ version of
sneut5as well as theesumNcode generator script.A test is added in
unit_test/test_rhsthat calls the RHS and Jacobian for a network and saves the output into a plotfile using either the C++ or Fortran network to make comparisons easy.Attached is the fcompare for the RHS and Jacobian for iso7 using the same thermodynamic ranges as inputs as for the
test_reactunit test.fc.txt
This PR also rearranges the screening API a bit to require zion and aion for all screened nuclei for convenience.
Right now the interfaces like
burn_typeandeos_typeas well asaion,aion_inv, andzionstill use 0-based indexing. The C++ iso7 liberally usesamrex::Array1Dwith 1-based indexing to make comparisons & porting from Fortran much easier.In the future we can standardize this, but that's probably best saved for another PR.