Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand requirement from 0.7 to 0.8 #71

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 21, 2020

Updates the requirements on rand to permit the latest version.

Changelog

Sourced from rand's changelog.

[0.8.0] - 2020-12-18

Platform support

  • The minimum supported Rust version is now 1.36 (#1011)
  • getrandom updated to v0.2 (#1041)
  • Remove wasm-bindgen and stdweb feature flags. For details of WASM support, see the getrandom documentation. (#948)
  • ReadRng::next_u32 and next_u64 now use little-Endian conversion instead of native-Endian, affecting results on Big-Endian platforms (#1061)
  • The nightly feature no longer implies the simd_support feature (#1048)
  • Fix simd_support feature to work on current nightlies (#1056)

Rngs

  • ThreadRng is no longer Copy to enable safe usage within thread-local destructors (#1035)
  • gen_range(a, b) was replaced with gen_range(a..b). gen_range(a..=b) is also supported. Note that a and b can no longer be references or SIMD types. (#744, #1003)
  • Replace AsByteSliceMut with Fill and add support for [bool], [char], [f32], [f64] (#940)
  • Restrict rand::rngs::adapter to std (#1027; see also #928)
  • StdRng: add new std_rng feature flag (enabled by default, but might need to be used if disabling default crate features) (#948)
  • StdRng: Switch from ChaCha20 to ChaCha12 for better performance (#1028)
  • SmallRng: Replace PCG algorithm with xoshiro{128,256}++ (#1038)

Sequences

  • Add IteratorRandom::choose_stable as an alternative to choose which does not depend on size hints (#1057)
  • Improve accuracy and performance of IteratorRandom::choose (#1059)
  • Implement IntoIterator for IndexVec, replacing the into_iter method (#1007)
  • Add value stability tests for seq module (#933)

Misc

  • Support PartialEq and Eq for StdRng, SmallRng and StepRng (#979)
  • Added a serde1 feature and added Serialize/Deserialize to UniformInt and WeightedIndex (#974)
  • Drop some unsafe code (#962, #963, #1011)
  • Reduce packaged crate size (#983)
  • Migrate to GitHub Actions from Travis+AppVeyor (#1073)

Distributions

  • Alphanumeric samples bytes instead of chars (#935)
  • Uniform now supports char, enabling rng.gen_range('A'..='Z') (#1068)
  • Add UniformSampler::sample_single_inclusive (#1003)

Weighted sampling

  • Implement weighted sampling without replacement (#976, #1013)
  • rand::distributions::alias_method::WeightedIndex was moved to rand_distr::WeightedAliasIndex. The simpler alternative rand::distribution::WeightedIndex remains. (#945)
  • Improve treatment of rounding errors in WeightedIndex::update_weights (#956)
  • WeightedIndex: return error on NaN instead of panic (#1005)

Documentation

  • Document types supported by random (#994)

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 21, 2020
@dependabot dependabot bot force-pushed the dependabot/cargo/rand-0.8 branch from ccb16fb to 8ce6fa8 Compare January 11, 2021 15:35
@commial
Copy link
Contributor

commial commented Jan 11, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/cargo/rand-0.8 branch from 8ce6fa8 to ede6816 Compare January 11, 2021 16:01
@commial
Copy link
Contributor

commial commented Jan 14, 2021

This might be an issue, as, from https://rust-random.github.io/book/update-0.8.html:

The minimum supported Linux kernel version is now 2.6.32.

Windows XP and stdweb are, as of getrandom version 0.2.1, no longer supported

@dependabot dependabot bot force-pushed the dependabot/cargo/rand-0.8 branch from ede6816 to c121815 Compare September 19, 2021 12:10
@dependabot dependabot bot force-pushed the dependabot/cargo/rand-0.8 branch from c121815 to 7194f7f Compare October 8, 2021 07:07
@Borber
Copy link

Borber commented Dec 14, 2021

So is there a way to upgrade from 0.7 to 0.8?

@commial
Copy link
Contributor

commial commented Jan 6, 2022

Actually, the libstd has now dropped some of the aforementioned support. In addition, getrandom seems to be on its way for integration in main Rust.

So, as long as MLA uses std, it could be considered working only on libstd supported platform.
Thus, this crate can be updated.

In a possible future no-std version, MLA could take the random seed as input, for instance in the MLAWriterConfig instanciation.

Ref:

@dependabot dependabot bot force-pushed the dependabot/cargo/rand-0.8 branch from 7194f7f to eaaa1d5 Compare January 8, 2022 14:13
@dependabot dependabot bot force-pushed the dependabot/cargo/rand-0.8 branch from eaaa1d5 to bd81a4f Compare January 8, 2022 14:35
@commial
Copy link
Contributor

commial commented Jan 8, 2022

Unfortunately, it seems that as long as #70 cannot be updated due to dependencies of dependencies version, this PR cannot land.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 10, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/rand-0.8 branch January 10, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants