Quote all string variables, and add spaces around variables "{{ var }}" #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #318 |
UnderGreen
approved these changes
Mar 26, 2018
gclough
pushed a commit
to gclough/postgresql
that referenced
this pull request
Mar 27, 2018
gclough
pushed a commit
to gclough/postgresql
that referenced
this pull request
Mar 27, 2018
gclough
pushed a commit
to gclough/postgresql
that referenced
this pull request
Mar 27, 2018
commit 971fc3c Author: Greg Clough <[email protected]> Date: Tue Mar 27 12:01:10 2018 +0100 Rebased from master commit 5c6a5f0 Merge: 871edb6 c657d9d Author: Greg Clough <[email protected]> Date: Tue Mar 27 12:00:08 2018 +0100 Merge branch 'add_missing_conf_parameters' of https://github.com/gclough/postgresql into add_missing_conf_parameters commit 871edb6 Author: Greg Clough <[email protected]> Date: Tue Mar 27 10:18:54 2018 +0100 Changed variables to match the "double-quoted" string standard, as introduced in \ANXS#319 commit 2468343 Author: Greg Clough <[email protected]> Date: Mon Mar 26 16:53:31 2018 +0100 Updated to use the standard "{{ var }}" format for new variables, rather than "{{var}}" commit 68359af Author: Greg Clough <[email protected]> Date: Sat Mar 24 15:30:30 2018 +0000 Crosscheck, and fix all missing parameters, defaults, etc. commit c657d9d Author: Greg Clough <[email protected]> Date: Tue Mar 27 10:18:54 2018 +0100 Changed variables to match the "double-quoted" string standard, as introduced in \ANXS#319 commit d009b72 Merge: 28b0e3a 28a6e9c Author: Greg Clough <[email protected]> Date: Tue Mar 27 10:13:16 2018 +0100 Merge branch 'master' of https://github.com/ANXS/postgresql into add_missing_conf_parameters Conflicts: defaults/main.yml commit 28b0e3a Author: Greg Clough <[email protected]> Date: Mon Mar 26 16:53:31 2018 +0100 Updated to use the standard "{{ var }}" format for new variables, rather than "{{var}}" commit 28a6e9c Merge: a1ab3cb 67e0fae Author: Sergei Antipov <[email protected]> Date: Mon Mar 26 11:52:03 2018 -0400 Merge pull request ANXS#319 from gclough/quote_all_enum_parameters Quote all string variables, and add spaces around variables "{{ var }}" commit 67e0fae Author: Greg Clough <[email protected]> Date: Mon Mar 26 12:23:19 2018 +0100 Octal numbers need to be quoted, otherwise they get converted to Decimal commit 42074a9 Author: Greg Clough <[email protected]> Date: Mon Mar 26 12:20:25 2018 +0100 Crosschecked, and found some that I missed. commit cb43081 Author: Greg Clough <[email protected]> Date: Mon Mar 26 11:48:01 2018 +0100 Quote all string variables, and add spaces around variables "{{ var }}" instead of "{{var}"" commit b4f67e3 Author: Greg Clough <[email protected]> Date: Sat Mar 24 15:30:30 2018 +0000 Crosscheck, and fix all missing parameters, defaults, etc. commit a1ab3cb Merge: 3861bc2 eabd1a0 Author: Sergei Antipov <[email protected]> Date: Fri Mar 23 12:46:42 2018 -0400 Merge pull request ANXS#313 from gclough/fix_galaxy_centos_name Fixed CenOS/RedHat naming... should be EL commit eabd1a0 Author: Greg Clough <[email protected]> Date: Fri Mar 23 15:27:39 2018 +0000 Fixed CenOS/RedHat naming... should be EL. Also added tags to help people find it on Galaxy commit 3861bc2 Merge: 73c77b4 f584dbb Author: Sergei Antipov <[email protected]> Date: Fri Mar 23 11:14:24 2018 -0400 Merge pull request ANXS#312 from gclough/update_meta_for_centos_redhat Added meta data for CentOS and RedHat, plus added tags commit f584dbb Author: Greg Clough <[email protected]> Date: Fri Mar 23 14:35:52 2018 +0000 Added meta data for CentOS and RedHat, plus added tags to help with searches commit 73c77b4 Merge: 7346fdb a3f45f9 Author: Sergei Antipov <[email protected]> Date: Mon Mar 19 19:23:31 2018 -0400 Merge pull request ANXS#307 from sebalix/use_postgresql_ext_for_extensions Use postgresql ext for extensions commit a3f45f9 Author: Greg Clough <[email protected]> Date: Thu Mar 15 18:04:13 2018 +0000 Added extra tests for travis to create extensions in "foobar" database commit e918dbe Author: Greg Clough <[email protected]> Date: Sat Mar 10 11:19:04 2018 +0000 Convert from using "psql" to using the Ansible module "postgresql_ext", which I suspect is a more reliable method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some issue with string variables (i.e. #254) that can also have options such as "on/off"... so to make it explicit, all string variables should be quoted.
I've also tidied up the usage of
{{var}}, and converted them all to be{{ var }}(with spaces)Finally, I tried to make quoting consistent, by moving all (most?) of the strings from using single quotes
' 'to double quotes" ".