Fix issue where deleting a workspace deletes the PVC incorrectly

Fix a regression caused by commit cbd3fd1. When deleting workspaces, if
there are no non-terminating workspaces left in the namespace, we delete
the common PVC rather than running cleanup jobs. However, the way the
check was written assumed that we were counting _all_ workspaces, and
would delete the common PVC if there were two workspaces in a namespace
and one was deleted.

Signed-off-by: Angel Misevski <[email protected]>

pkg/provision/storage/commonStorage.go

@@ -94,7 +94,7 @@ func (p *CommonStorageProvisioner) CleanupWorkspaceStorage(workspace *dw.DevWork
 
 	// If the number of common + async workspaces that exist (started or stopped) is zero,
 	// delete common PVC instead of running cleanup job
-	if totalWorkspaces > 1 {
+	if totalWorkspaces > 0 {
 		return runCommonPVCCleanupJob(workspace, clusterAPI)
 	} else {
 		sharedPVC := &corev1.PersistentVolumeClaim{}