fix(NLog): revert to use NLog internal JsonSerializer #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NLog internal json serializer do not support types that STJ does, thus seemed smart to use STJ. But STJ doesn't fallback to Convert.ToString() for unsupported types (e.g. Type). Instead in Logging is common to expect the logging parameters by using ToString() / Convert.ToString() and by extension also when serializing the Structured Logging json. Revert to Default Json serializer until a better option is devised, e.g. by agumenting the STJ to fallback to string for unsupported types.
AndreaCuneo
force-pushed
the
bugfix/NLog_JsonSerializer_Error
branch
from
1103157
to
08ff569
Compare
MarcoGix
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NLog internal json serializer do not support types that STJ does, thus seemed smart to use STJ. But STJ doesn't fallback to Convert.ToString() for unsupported types (e.g. Type).
Instead in Logging is common to expect the logging parameters by using ToString() / Convert.ToString() and by extension also when serializing the Structured Logging json.
Revert to Default Json serializer until a better option is devised, e.g. by agumenting the STJ to fallback to string for unsupported types.