people forgot to update the sub version... #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GorgonMeducer
changed the title
|
Hi @GorgonMeducer, Thanks for pointing this out. You are apperently right and this totally slipped through. Damn. -Jonatan |
|
I have seen significant differences between CMSIS5.7.0 and CMSIS 5.8.0. The only way to write a compatible code is using the sub version macro... Thank you for accepting this merge request. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMSIS core version should be 5.5.0, and people forgot to update the cmsis_version.h
We should avoid this issue in the future.