Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core_ca.h defines for ISR and SGIR_INTID #215

Open
NVMarkovich opened this issue Jan 24, 2025 · 4 comments
Open

core_ca.h defines for ISR and SGIR_INTID #215

NVMarkovich opened this issue Jan 24, 2025 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@NVMarkovich
Copy link

NVMarkovich commented Jan 24, 2025

  1. In core_ca.h, lines 644; 647; 650, the ISR_A_Pos, ISR_I_Pos, ISR_F_Pos should be not 13U, 12U, 11U, but 8U, 7U, 6U respectively, as per structure at lines 636-638.
  2. In the same file, line 921, GICDistributor_SGIR_INTID_Msk should be not 0x7U, but 0xFU, as the INTID is 4 bits.
  3. GICInterface_HPPIR_INTID_Msk should be 0x3FFU instead of 0xFFFFFFU.
@JonatanAntoni
Copy link
Member

@NVMarkovich, thanks for raising this. Would you mind to raise a pull-request contributing the requested changes?

@JonatanAntoni JonatanAntoni added the bug Something isn't working label Jan 24, 2025
@NVMarkovich
Copy link
Author

NVMarkovich commented Jan 24, 2025 via email

@JonatanAntoni
Copy link
Member

@NVMarkovich, the files you are referring to are community contributed.

@NVMarkovich
Copy link
Author

ok, when I finish reviewing the whole file, I will consider raising a pull-request. Meanwhile I plan to add the further new-found issues in the initial message, if You don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants