Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acle: Correct usdot specification on AArch32 #19

Merged
merged 1 commit into from
Jul 23, 2021
Merged

acle: Correct usdot specification on AArch32 #19

merged 1 commit into from
Jul 23, 2021

Conversation

TamarChristinaArm
Copy link
Contributor

Fixes #18 by marking all the intrinsics as supported on AArch32.

@TamarChristinaArm TamarChristinaArm force-pushed the fix-usdot-specification branch from 2e20943 to 45f7fb5 Compare July 22, 2021 09:27
@fpetrogalli fpetrogalli added this to the 2021Q3 milestone Jul 22, 2021
@fpetrogalli fpetrogalli added neon_intrinsics next release PRs that need to be considered for the next release. labels Jul 22, 2021
@fpetrogalli
Copy link
Contributor

@TamarChristinaArm - I think you are using an old version of the next-release branch. The new version has started a new changelog on top of the RST file (see #17). Please rebase on top of current next release and add an item to the changelog, somethign like Correct usdot specification on AArch32 (Note that you'll have to change also the template RST at neon_intrinsics/advsimd.template.rst.

Thanks!

@fpetrogalli fpetrogalli self-assigned this Jul 22, 2021
@TamarChristinaArm TamarChristinaArm force-pushed the fix-usdot-specification branch from 45f7fb5 to ca3246d Compare July 23, 2021 06:27
@TamarChristinaArm
Copy link
Contributor Author

Note that you'll have to change also the template RST at neon_intrinsics/advsimd.template.rst.

still have to do this.

@TamarChristinaArm TamarChristinaArm force-pushed the fix-usdot-specification branch from ca3246d to 5a973ec Compare July 23, 2021 13:35
fpetrogalli
fpetrogalli approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@fpetrogalli fpetrogalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TamarChristinaArm !

@fpetrogalli fpetrogalli merged commit a2ece70 into ARM-software:next-release Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpetrogalli fpetrogalli fpetrogalli approved these changes

Assignees

@fpetrogalli fpetrogalli

Labels
next release PRs that need to be considered for the next release.
Projects
None yet
Milestone
2021Q3
Development

Successfully merging this pull request may close these issues.
2 participants
@TamarChristinaArm @fpetrogalli