Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nRF5xn::getVersion return (Unknown) with version 8 soft device #29

Closed
aracosta1 opened this issue Jul 29, 2015 · 1 comment
Closed

nRF5xn::getVersion return (Unknown) with version 8 soft device #29

aracosta1 opened this issue Jul 29, 2015 · 1 comment

Comments

@aracosta1
Copy link

The getVersion function only check for version 0x07 of the softdevice. Should be added a new case for version 8 softdevice.
Also the string should contain the version_number, not only subversion.
rgrover pushed a commit that referenced this issue Jul 29, 2015
fix #29: add mention of version number to the version string.
71d6c41
@rgrover
Copy link
Contributor

rgrover commented Jul 29, 2015

will be merged to master with the next release.

@rgrover rgrover closed this as completed in 6cdf4e1 Aug 7, 2015
jslater8 pushed a commit to jslater8/nRF51822 that referenced this issue Aug 10, 2015
@jslater8
fix ARMmbed#29: support getVersion for v8 of the softdevice.
2a278b0
jslater8 pushed a commit to jslater8/nRF51822 that referenced this issue Aug 10, 2015
@jslater8
fix ARMmbed#29: add mention of version number to the version string.
3aaebd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgrover @aracosta1