Fix incorrect handles of characteristics descriptors. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable descriptorCount is used as an index, and this index is used to set the handle of the last registered descriptor. Prior to this fix, descriptorCount was incremented before the handle the update of the handle of a characteristics. Short story, all characteristics descriptors handle were equaols to 0 instead of the actual value.
|
Automatic CI verification build not done, please verify manually. |
|
@rgrover any comment on this ? |
|
thanks. looks better now. |
|
retest this please. |
pan-
added a commit
that referenced
this pull request
Feb 16, 2016
Fix incorrect handles of characteristics descriptors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable descriptorCount is used as an index, and this index is used to set
the handle of the last registered descriptor.
Prior to this fix, descriptorCount was incremented before the handle the update
of the handle of a characteristics.
Short story, all characteristics descriptors handle were equaols to 0 instead
of the actual value.